[INSTRM-1987] Find an analyze mis-identification in the cobra convergence Created: 01/Jun/23 Updated: 14/Oct/23 Resolved: 14/Oct/23 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_mcsActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | karr | Assignee: | karr |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Description |
|
Develop an automatic method for flagging mis-identified cobras from convergence data, for further analysis and fine-tuning the algorithm. |
| Comments |
| Comment by arnaud.lefur [ 23/Jun/23 ] |
|
We were discussing about this during the last ICS-PFI-MCS telecon, have you started to work on this yet ? |
| Comment by karr [ 08/Jul/23 ] |
|
I'm working on an way of flagging misidentifications automatically, but haven't got results yet. |
| Comment by karr [ 15/Aug/23 ] |
|
I've got a method for flagging potential misidentification, and am adding some diagnostic plotting routines to keep track of what's happening, and where things go wrong. We are getting cases here and there, and the effect of the misidentification on convergence is very similar to what was predicted by simulations. |
| Comment by karr [ 18/Aug/23 ] |
|
Please add a comment if you have have favourite misidentifications to contribute. |
| Comment by chyan [ 18/Aug/23 ] |
|
97904: theta |
| Comment by karr [ 01/Sep/23 ] |
|
We need to look at the column definitions in cobra_target. There are pfi_nominal_x_mm and pfi_target_x_mm. Originally, pfi_target contained the final target postion for the convergence run, and pfi_nominal was supposed to contain the target position for each iteration. The latter took a while to implement, however, it looks like pfi_target was changed to contain the target for each iteration, while pfi_nominal contains the centre position of the patrol region. The cobra identification was using pfi_nominal, rather than pfi_target, which results in misidentifications in some cases. Changing either the table or the identification code will get rid of ~2/3 of the misidentifications in the regular convergence cases. Even with this problem, mis-identification are rare. Of 151 runs analyzed, 36 incidents were flagged. |
| Comment by yuki.moritani [ 14/Oct/23 ] |
|
The code has been tested and merged to master, so I close this ticket. |