[INSTRM-1927] set pfiCenter and fiberStatus correctly when writing pfsConfig. Created: 20/Apr/23  Updated: 20/Apr/23  Resolved: 20/Apr/23

Status: Done
Project: Instrument control development
Component/s: ics_fpsActor
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: arnaud.lefur Assignee: arnaud.lefur
Resolution: Done Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Story Points: 1

 Description   

Looking at the cobra_match entries, I've noticed that I did some mistakes in making pfsConfig back in november.
I was getting 2394 matches each time which is unlikely, because the pfi_center_(x,y)_mm. are set to the theorical black dot position if there is no match, I don't like that.

  • I'll put NaN where there are no measured mm position.
  • I will set fiberStatus to BROKEN where FIBER_BROKEN_MASK.
  • I will set fiberStatus to BLACKSPOT where pfi.status==OK and where there is no match.

I wonder even on fiberId 3, which is labelled as broken even if it's not broken-broken it's just low throughput eg I have a match with mcs and I have a spectra on sps.

 Comments   
Comment by arnaud.lefur [ 20/Apr/23 ]

merged as 1.6.1

Generated at Sat Feb 10 16:41:06 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.