[INSTRM-1900] create pfsConfig after homing cobras Created: 18/Mar/23  Updated: 21/Apr/23  Resolved: 21/Apr/23

Status: Done
Project: Instrument control development
Component/s: ics_fpsActor
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: arnaud.lefur Assignee: arnaud.lefur
Resolution: Done Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Story Points: 2
Sprint: PreEng11Apr1

 Description   

When homing we take an mcs exposure, so we need where the cobras are.
Use those positions to create a pfsConfig file and set pfiNominal /pfiCenter / targetType / fiberStatus correctly.
for a non detected cobra, just set pfiCenter to nan and fiberStatus to BLACKSPOT.

 Comments   
Comment by arnaud.lefur [ 18/Mar/23 ]

Kiyoto Yabe on a side but slightly related topic, when you generate pfsDesign file, where is the code that's set targetType and fiberStatus ?
I said that before, but since some of the "broken" cobras are collecting photon for the spectrograph, we have a spectra for it and we know where thy are on the sky, so I propose we set those to :
targetType = UNASSIGNED and fiberStatus=GOOD
And of course, for the one which are broken - broken, eg, no flux, we set :
targetType = UNASSIGNED and fiberStatus=BROKEN

Do you agree ?

Comment by Kiyoto Yabe [ 18/Mar/23 ]

I think that part is somewhere in https://github.com/Subaru-PFS/ets_pointing/blob/main/pfs_design_tool/pointing_utils/designutils.py

OK, so we don't introduce a specific fiberStatus like BROKENCOBRA and use UNASSIGNED target type as Paul suggested in DAMD-143?

Comment by arnaud.lefur [ 15/Apr/23 ]

Yes, I do agree with Paul proposal.
And if we want to be consistent I think we should also add two new targetType :

  • HOME
  • BLACKSPOT
Comment by arnaud.lefur [ 21/Apr/23 ]

merged as :

  • iicActor:2.3.8
  • fpsActor:1.6.2
  • actorkeys:1.6.7
  • datamodel:w.2023.16a
Generated at Sat Feb 10 16:40:50 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.