[INSTRM-1877] Transformation of US-MCS is still not working Created: 03/Mar/23  Updated: 31/Mar/23  Resolved: 31/Mar/23

Status: Done
Project: Instrument control development
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: yuki.moritani Assignee: chyan
Resolution: Done Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Figure 1-94.png     PNG File Figure_visit89208.png     File INSTRM-1851.ipynb    
Sprint: PreEng11Apr1

 Description   

At PFI informal meeting, it was reported that there is still a problem with transformation of us-mcs.



 Comments   
Comment by chyan [ 13/Mar/23 ]

Here is the problem I encountered. See plot

Comment by yuki.moritani [ 14/Mar/23 ]

This suggests that the camera is titled?

Comment by yuki.moritani [ 15/Mar/23 ]

I took one image after adjusting camera position to have the same scale as before (i.e. on the test stand). the figures looks like this: 

Note: I changed distortion parameters under USMCSTransform class to the following values:

[-271, 376, insrot, -0.924, -2.2564758e-13]

Comment by price [ 27/Mar/23 ]

A merge of this ticket branch to master broke pfs_utils: the code doesn't compile or pass tests. I see that the ticket is still open, so perhaps it was merged by accident? In any case, please fix it or revert the merge quickly, as this breaks the 2D pipeline.

Comment by chyan [ 31/Mar/23 ]

merge to master.

Generated at Sat Feb 10 16:40:37 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.