[INSTRM-1845] Modify GFM reflecting the current cable connection Created: 20/Jan/23 Updated: 27/Jan/23 Resolved: 27/Jan/23 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | pfs_utils |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | yuki.moritani | Assignee: | yuki.moritani |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Reviewers: | hassan |
| Description |
|
SM3 and hence SM2 locations were swapped, and now the cable B2 is connected to SM3. cobraId-fiberID relation is the same, but light path has changed. Columns id(BA) and id(BC) should be updated accordingly. |
| Comments |
| Comment by yuki.moritani [ 25/Jan/23 ] |
|
Before uploading the modified file, I am wondering whether the filename, which includes the date of revision, should be kept. Changing the filename may cause the troubles for other people, so it might be better to keep the same filename..? (maybe we could delete the date from the filename?) Do you have any suggestions/opinions? > price hassan rhl |
| Comment by price [ 25/Jan/23 ] |
|
I think you should rely on git for versioning, not filenames. |
| Comment by hassan [ 25/Jan/23 ] |
|
I think we should be able to drop the date of the revision from the filename. The versions are controlled as git commits anyway. I am hoping most people access the GFM using the pfs_utils fiberids.py utility, so hopefully dropping the revision date does not impact on most people. Incidentally, fiberids.py seems to be able to read in any file of name grandfibermap*.txt, so that may not need to be updated following the renaming of the filename. |
| Comment by yuki.moritani [ 25/Jan/23 ] |
|
Thank you for prompt comments. Yes, I can/should rely on git for versioning, rather than filename. So if you are fine to delete the date from the filename, may I do so under this ticket, assuming/hoping that nothing will break severely? |
| Comment by hassan [ 25/Jan/23 ] |
|
I'm fine with making the change under this ticket. |
| Comment by hassan [ 27/Jan/23 ] |
|
Changes in pull request https://github.com/Subaru-PFS/pfs_utils/pull/57 look fine to me. |
| Comment by yuki.moritani [ 27/Jan/23 ] |
|
Thank you, Hassan, for review. I merged the banch. |