[INSTRM-1841] Introduce pfsDesign/Config validation code Created: 14/Jan/23 Updated: 09/Jul/23 Resolved: 09/Jul/23 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | hassan | Assignee: | Kiyoto Yabe |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
As reported on slack: https://sumire-pfs.slack.com/archives/C9TDPMVHT/p1671252144208469 A number of targets in pfsDesign 0x031107ae86f9db65 have unrealistic PFI positions, in that for each target the distance from the cobra center is greater than the L1+L2 arm lengths. To avoid such situations happening in the future, I propose introducing a pfs_utils utility that validates the contents of a given pfsDesign. This utility would include at least a check for the PFI target positions. |
| Comments |
| Comment by yuki.moritani [ 26/May/23 ] |
|
We talked about this topic at ICS/PFI telecon on 26 May 2023. Kiyoto (Kiyoto Yabe) will look into how to implement validation when pfsDesign is made. Chi-Hung (chyan) has the scripts to check design, and share with Kiyoto. |
| Comment by Kiyoto Yabe [ 09/Jun/23 ] |
|
The subaru_fiber_allocation code now checks and provides WARNING if the distance exceeds L1+L2 arm length. I can replace that part if chyan provides a better code. |
| Comment by Kiyoto Yabe [ 09/Jun/23 ] |
|
It didn't detect such case in the design file for visit=93325 (if the code works properly). If the geometry in opDB is old, probably we need to think about |
| Comment by Kiyoto Yabe [ 07/Jul/23 ] |
|
In any case, this may be useful, so I'll merge the change and close this ticket. |