[INSTRM-1780] Remove automatic creation of spectroIds in ICS butler. Created: 03/Nov/22  Updated: 05/Nov/22  Resolved: 05/Nov/22

Status: Done
Project: Instrument control development
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Normal
Reporter: cloomis Assignee: cloomis
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The ICS butler is minuscule, cut down, version of the DRP butler, and is used both by consumers of ICS data – to load black dots or PFI configs, say – and by the actors which create raw data files. Those actors often use a SpectroIds object to inspect the environment (DNS info, basically) to figure out what site they are running at, or what camera and or spectrograph module they are running on/for.

The pfs.utils Butler constructor accepts such an object, and if none is passed in creates one. This was sketchy at the best of times, but is very bad now because the SpectroIds class was moved out of pfs_utils and into ics_utils.

So, if no specIds object is passed in to the Butler() constructor, do not create one. But also add a dataId dictionary argument to cover the basic use case, where we are only interested in, say, one camera.



 Comments   
Comment by cloomis [ 05/Nov/22 ]

Merged at 9dda9fa, tagged 7.1.3

Generated at Sat Feb 10 16:39:23 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.