[INSTRM-1758] Update exit conditions for centroid routine Created: 14/Oct/22 Updated: 11/Nov/22 Resolved: 11/Nov/22 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_mcsActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | karr | Assignee: | karr |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | preEngRun08Nov |
| Description |
|
When bad data are passed to the centroid routine (too low threshold, overly illuminated image), the C level centroid code should exit gracefully before timing out. At the last commissioning run, we found the current conditions for exiting are too conservative; I need to test for best values and update. |
| Comments |
| Comment by karr [ 19/Oct/22 ] |
|
Added an additional exit condition after exiting individual threads; the process of combining threads has an O(n2) operation that is fast with reasonable numbers of spots, but was hanging the process when nSpot > 100,000. |
| Comment by karr [ 28/Oct/22 ] |
|
Tested the routine locally, will test on the real system before merging and closing. |
| Comment by karr [ 07/Nov/22 ] |
|
Tested compilation and run on system with new python environment. |
| Comment by karr [ 07/Nov/22 ] |
|
merged to master |