[INSTRM-1748] FiberStatus information not propagated to PfsDesign files Created: 07/Oct/22 Updated: 30/Nov/22 Resolved: 30/Nov/22 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | hassan | Assignee: | monodera |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Story Points: | 3 | ||||||||||||||||||||
| Sprint: | preEngRun08Nov | ||||||||||||||||||||
| Description |
|
With the exception of SuNSS-based pfsDesign files (designId=0xdeadbeef), it seems that all pfsDesign files generated so far do not contain any fiberStatus information other than GOOD. However, as yuki.moritani tells me, of the 2394 available science fibers, 7 are broken, two of those fed to SM1. Please propagate those broken fibers into future pfsDesign files. |
| Comments |
| Comment by rhl [ 07/Oct/22 ] |
|
I believe that the canonical source of Truth is the GFM, but we should be sure that we all agree. |
| Comment by monodera [ 07/Oct/22 ] |
|
I don't see any status information in the attributes of pfs.utils.fiberids.FiberIds() and in the GFM file. I think that we can add a column for the fiber status in the GFM file and use them as the default values in pfs.utils.pfsDesignUtils.makePfsDesign() if the code can read the GFM file (and set to GOOD as currently implemented if the code failed to read the GFM file, which is not a good sign, thoguh). |
| Comment by yuki.moritani [ 07/Oct/22 ] |
|
Well.. I'm confused with Robert's comment, he is mentioning the current situation, or he is proposing to use GFM. I feel that the built-up instrument information such as "broken fibers" should be handled in the same way as the others. Disabled fiducial fiber ID is stored pfs_instdata, and xml file (under pfs_instdata too) convers the broken fibers on PFI side. So I think these information should be passed when pfsDesign file is created. In addition, .xml file should cover all the broken fibers ( |
| Comment by hassan [ 07/Oct/22 ] |
|
I also think that having the PfiDesign class, which is currently in ics_cobraCharmer and can access the cobra XML files, should be moved to pfs_utils to help with propagating fiber status information to pfsDesign files (INSTRM-1243). |
| Comment by rhl [ 08/Oct/22 ] |
|
I'm sorry that I confused things. I thought we'd decided to use the GFM as the source of truth, but the data in pfs_instdata would be another fine place – I more wanted to emphasise that we need to decide than (apparently incorrectly) propose the GFM. |
| Comment by Kiyoto Yabe [ 01/Nov/22 ] |
|
This will be fixed as a part of |
| Comment by Kiyoto Yabe [ 30/Nov/22 ] |
|
This has been implemented in the latest script, so I close this ticket (but see |