[INSTRM-1729] Cobra .xml file is missing two broken fiber of SM1 Created: 03/Oct/22  Updated: 10/Dec/22  Resolved: 10/Dec/22

Status: Done
Project: Instrument control development
Component/s: pfs_instdata
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: yuki.moritani Assignee: chyan
Resolution: Done Votes: 0
Labels: CanBeClosed, EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to INSTRM-1748 FiberStatus information not propagate... Done
relates to INSTRM-1270 Track fiber transmission Open
Story Points: 1
Sprint: preEngRun08Nov, PreEngRun09Dec

 Description   

Cobra xml file marks  broken fibers (in "Status" tag), and the latest version (20220923) has only 5 broken fibers, which are broken at Cable C. However,  there are two more broken fiber at Cable A, SM1. Namely,

#mod #cm2 #sp #fh #fid
4 2 1 3 3
12 21 1 114 114

I think these two fibers should be marked as broken fibers too. (Note: strictly speaking, fid=3 is fiber with very low transmission, not completely broken.)

 Comments   
Comment by chyan [ 14/Oct/22 ]

Looking at the current definition from pfiDesign, we have:

COBRA_OK_MASK = 0x0001 # a synthetic summary bit: 1 for good, 0 for bad.
COBRA_INVISIBLE_MASK = 0x0002 # 1 if the fiber is not visible
COBRA_BROKEN_THETA_MASK = 0x0004 # 1 if the phi motor do not work
COBRA_BROKEN_PHI_MASK = 0x0008 # 1 if the theta motor does not work

So, we do need new definition to track this situation.

Comment by yuki.moritani [ 21/Oct/22 ]

At the meeting about ASIAA task on 20-21 October 2022, we came up one proposal to add three more bits to describe which part of the fiber is broken: namely, 

 

FIBER_A_BROKEN: 0x0010  # 5th bit is 1 if cable A is broken
FIBER_B_BROKEN: 0x0020  # 6th bit is 1 if cable B is broken
FIBER_C_BROKEN: 0x0040  # 7th bit is 1 if cable C is broken

 

 

Comment by hassan [ 27/Oct/22 ]

In order to implement this change as soon as possible, yuki.moritani and I propose that if there are no objections to the proposal by Yuki above by the ICS/PFI telecon 2022-10-28, that proposal is accepted and will be implemented (at least as a medium-term solution).

Comment by chyan [ 10/Dec/22 ]

This ticket is closed since the branch is merged to master

Generated at Sat Feb 10 16:38:47 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.