[INSTRM-1726] pfilamps fits key should always be set to False if requested time is 0 second Created: 29/Sep/22  Updated: 26/Oct/22  Resolved: 26/Oct/22

Status: Done
Project: Instrument control development
Component/s: ics_pfilampsActor
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: arnaud.lefur Assignee: cloomis
Resolution: Done Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to INSTRM-1727 fixing pfilamps header keys for septe... Done
Story Points: 2
Sprint: preEngRun08Nov

 Description   

During last engineering run, some arcs has been taken using gen2:
iic scienceArc hgcd=0.0 argon=0.0 neon=10 krypton=0.0 duplicate=1 cam=b1,r1

Some requested lamp time has been set to 0, I suppose because of how gen2 commands are written, that's fine with me, but we have to be careful about book-keeping.

conda-ics) alefur@shell-ics:~$ fitsheader /data/raw/2022-09-24/sps/PFSA07999012.fits |grep 'W_AIT'
W_AITNEO=                    T / Neon lamp was on                               
W_AITARG=                    T / Argon lamp was on                              
W_AITKRY=                    T / Krypton lamp was on                            
W_AITXEN=                    F / Xenon lamp was on                              
W_AITHGC=                    T / HgCd lamp was on                               
W_AITQTH=                    F / Halogen lamp was on                            
(conda-ics) alefur@shell-ics:~$ fitsheader /data/raw/2022-09-24/sps/PFSA07999012.fits |grep 'W_CL'
W_CLNEOT=                   10 / Neon lamp request time                         
W_CLARGT=                    0 / Argon lamp request time                        
W_CLKRYT=                    0 / Krypton lamp request time                      
W_CLXENT=                    0 / Xenon lamp request time                        
W_CLHGCT=                    0 / HgCd lamp request time                         
W_CLQTHT=                    0 / Halogen lamp request time

As you can see, for that visit, the flag has been set to True with time=0.
I'm not sure how drp interpret that, but still I think that flag should be set to False

 Comments   
Comment by cloomis [ 26/Oct/22 ]

Merged at fda6ad1, tagged 1.3.1

Generated at Sat Feb 10 16:38:45 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.