[INSTRM-1706] renew FF positions based on measurement by AG cameras Created: 16/Sep/22 Updated: 23/Sep/22 Resolved: 20/Sep/22 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | pfs_instdata |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | yuki.moritani | Assignee: | yuki.moritani |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Sprint: | preEngRun07Sep | ||||||||
| Description |
|
At present, FF position is by xy-scanner measurement. Recently the xy-scanner position for AG camera was compared to those measured using AG images (i.e. sky): dX = -1.748mm (xy scanner -> sky images) Based on this comparison. FF position needs to be renewed. |
| Comments |
| Comment by yuki.moritani [ 17/Sep/22 ] |
|
fiducial_positions_20220916.csv Either cloomis or hassan , could you please upload to Github, after checking? |
| Comment by cloomis [ 17/Sep/22 ] |
|
I propose doing the same thing as for black dots and xml files: rename the existing `fiducial_positions.csv` to `fiducial_positions_20210524.csv`, add the new file as named, and add a symbolic_link to the new file from `fiducial_positions.csv`: a cheap way to make the history both explicit and available. [ and the new name should of course be 20220916 instead of 20210916.... ] |
| Comment by yuki.moritani [ 17/Sep/22 ] |
|
It sounds a good idea. And I replaced the file by correcting the date. By the way I have one question: should we renew dot position, at least initial position for re-measurement? |
| Comment by cloomis [ 17/Sep/22 ] |
|
Merged at 76c6f3f, tagged 1.2.0 |
| Comment by yuki.moritani [ 17/Sep/22 ] |
|
cloomis my apologies, Hassan double checked my position and found discrepancy. After discussion, we think fiducial_positions_20220916c.csv I'm very sorry for bothering you (I was in too rush). Could you replace the file? (you could omit "c" on the repository, as precious one was wrong.) |
| Comment by yuki.moritani [ 20/Sep/22 ] |
|
The new file has been linked on shell-ics, so I close this ticket (again). |
| Comment by yuki.moritani [ 23/Sep/22 ] |
|
For recordings: the formula of the transformation is as follows:
|