[INSTRM-1687] Separating some columns from cobra_target table into cobra_move Created: 29/Aug/22 Updated: 08/Jul/23 Resolved: 08/Jul/23 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | chyan | Assignee: | Kiyoto Yabe |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun, opDB | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
cobra_move.png
cobra_target.png
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Description |
|
According to the discussion in the software meeting, cobra_target current contains two kinds cobra information, before and after the move, respectively. We should separate them into two different tables. So that cobra_target keeps the information from the prediction and cobra_move contains the actual move measured from MCS/FPS. |
| Comments |
| Comment by Kiyoto Yabe [ 01/Sep/22 ] |
|
Does this mean that we need a new table `cobra_move` as well? Or can we utilize the existing table `cobra_match`? Anyway, could you tell me specifically which columns should be separated out from `cobra_target` please? |
| Comment by Kiyoto Yabe [ 09/Sep/22 ] |
|
According to the meeting with chyan yesterday, Kiyoto Yabe comes up the change in schema after receiving a list of contents in each table (`cobra_target` and `cobra_move`) once chyan manages to enter `pfic` and get information. |
| Comment by Kiyoto Yabe [ 13/Sep/22 ] |
|
I pushed my change to the topic branch. Basically I just separate out columns related to the motor movement (see below). chyan, could you check this change or send me your list of columns in `cobra_move`. Thanks.
|
| Comment by cloomis [ 13/Sep/22 ] |
|
If the distinction is before move vs. after, is that right? before: config and model ids, target mm/theta/phi/steps/ontimes : the things which are calculated and sent to the fpga after: measured mm |
| Comment by Kiyoto Yabe [ 15/Sep/22 ] |
|
I think what I heard from chyan is different. Any comments, chyan? |
| Comment by hassan [ 30/Nov/22 ] |
|
Kiyoto Yabe chyan where do we stand on this ticket now? Can the tables be separated according to cloomis 's comment above? |
| Comment by Kiyoto Yabe [ 01/Dec/22 ] |
|
We didn't have much time to talk about this during the last run. I would like to understand the both opinions before making changes. Anyway, I think changing schema before the next run is a bit risky. |
| Comment by Kiyoto Yabe [ 19/Dec/22 ] |
|
chyan, cloomis, & Kiyoto Yabe all agreed with the change. |
| Comment by yuki.moritani [ 04/Mar/23 ] |
|
Recording from ICS/PFI+MCS meeting on 3 Mar 2023. Test will be done after PFI is back on US (the week of 3/6). Schema has changed, but opDB has not been updated yet. |
| Comment by arnaud.lefur [ 07/Jul/23 ] |
|
Kiyoto Yabe chyan is reporting some constraint violation when he's doing the insert. |
| Comment by Kiyoto Yabe [ 08/Jul/23 ] |
|
File a new ticket |
