[INSTRM-1685] Arrange for agccActor to call `gen2 updateTelStatus` for each exposure Created: 19/Aug/22 Updated: 20/Sep/22 Resolved: 20/Sep/22 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_agccActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | cloomis |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 4 |
| Sprint: | preEngRun07Sep |
| Description |
|
We need to trigger updates of the telescope tables and MHS keywords for each agc exposure. That is done by commanding gen2Actor with `gen2 updateTelStatus caller=agcc` to record the latest gen2 status information. For an example, see mcsActor's McsCmd.py:getNextFileIds, but we need to handle subvisits differently. |
| Comments |
| Comment by Yoshida, Hiroshige [ 02/Sep/22 ] |
|
Did you mean agActor - it makes that call already. |
| Comment by hassan [ 08/Sep/22 ] |
|
cloomis so is this ticket still valid? |
| Comment by cloomis [ 15/Sep/22 ] |
|
The agActor does call updateTelStatus correctly on behalf of the agccActor. But when the agccActor is called directly it needs to call gen2. Figure out a way for the agccActor to distinguish this case, then call gen2 updateTelStatus itself. |
| Comment by cloomis [ 20/Sep/22 ] |
|
Actually, the agccActor already does this last bit: if an expose visit= argument is not passed in from the agActor, the agccActor then gets its own visit, with gen2 getVisit caller=agcc. getVisit always calls updatetelStatus. |
| Comment by hassan [ 20/Sep/22 ] |
|
This ticket has been closed with status 'DONE' but no corresponding ticket branch. What was the actual change between the June 2022 run and now, that actually addresses the problem? I understand that if the iicActor had been used during the June run, the telescope tables would have been updated fine. And I understand that during the June run, the agActor, rather than the IIC, had been used. So presumably the agActor, at the time of the June run, had not been updating the telescope tables. Yoshida-san mentions in an earlier comment in this ticket that the agActor makes the gen2 updateTelStatus call already. So had that feature been added to agActor after the June run? |