[INSTRM-1673] gatevalve open underVacuum on b3 started to open then closed by itself. Created: 21/Jul/22  Updated: 09/Nov/22  Resolved: 09/Nov/22

Status: Done
Project: Instrument control development
Component/s: ics_xcu_interlock
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: cloomis Assignee: shope
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Within gv_open was received with the turbo at speed and the pressures ok, gv_request was asserted, gv_closed dropped (showing that the GV actually moved), then immediately gv_request was dropped and gv_closed reseen.

All within 0.4s.

 

```2022-07-20T15:58:35.633 xcu_b3 i interlockpressures=0.00,0.00;gatevalve=0x74,closed,closed;gvmask="0xc7";interlock=0b1110100,"turbo_at_speed, pressure_equal, vacuum_ok, gv_closed"
'"22-07-20T15:58:35.634 xcu_b3 d text="sending '?V852
2022-07-20T15:58:35.697 xcu_b3 d text="recv '=V852 1500;000502BC'"
2022-07-20T15:58:35.697 xcu_b3 i turbospeed="90000"
2022-07-20T15:58:35.698 xcu_b3 i turbostatus=0x000502bc,"Above normal speed, Vent valve energized, Start command active, Serial enable active, Above 50% full speed, Serial control mode, bit 17, bit 19"
2022-07-20T15:58:35.698 xcu_b3 d text="sending '~gStat,all\n'"
2022-07-20T15:58:35.704 xcu_b3 d text="recv '~gStat,all'"
2022-07-20T15:58:35.974 xcu_b3 d text="recv '01110100'"
2022-07-20T15:58:35.974 xcu_b3 d text="sending '~gP,all\n'"
2022-07-20T15:58:35.979 xcu_b3 d text="recv '~gP,all'"
2022-07-20T15:58:36.320 xcu_b3 d text="recv '-1.93, -0.38'"
2022-07-20T15:58:36.320 xcu_b3 i interlockpressures=0.00,0.00;gatevalve=0x74,closed,closed;gvmask="0xc7";interlock=0b1110100,"turbo_at_speed, pressure_equal, vacuum_ok, gv_closed"
2022-07-20T15:58:36.321 xcu_b3 d text="sending '~gStat,all\n'"
2022-07-20T15:58:36.327 xcu_b3 d text="recv '~gStat,all'"
2022-07-20T15:58:36.660 xcu_b3 d text="recv '01110100'"
2022-07-20T15:58:36.661 xcu_b3 d text="sending '~gP,all\n'"
2022-07-20T15:58:36.665 xcu_b3 d text="recv '~gP,all'"
2022-07-20T15:58:37.007 xcu_b3 d text="recv '-1.91, -0.41'"
2022-07-20T15:58:37.008 xcu_b3 i interlockpressures=0.00,0.00;gatevalve=0x74,closed,closed;gvmask="0xc7";interlock=0b1110100,"turbo_at_speed, pressure_equal, vacuum_ok, gv_closed"
2022-07-20T15:58:37.008 xcu_b3 d text="sending '~gStat,all\n'"
2022-07-20T15:58:37.014 xcu_b3 d text="recv '~gStat,all'"
2022-07-20T15:58:37.348 xcu_b3 d text="recv '11110001'"
2022-07-20T15:58:37.349 xcu_b3 i gatevalve=0xf1,unknown,open;gvmask="0xce";interlock=0b11110001,"open_cmd, turbo_at_speed, pressure_equal, vacuum_ok, gv_request"
2022-07-20T15:58:37.549 xcu_b3 d text="sending '~gStat,all\n'"
2022-07-20T15:58:37.553 xcu_b3 d text="recv '~gStat,all'"
2022-07-20T15:58:37.691 xcu_b3 d text="recv '11110000'"
2022-07-20T15:58:37.691 xcu_b3 i gatevalve=0xf0,unknown,blocked;gvmask="0xcf";interlock=0b11110000,"open_cmd, turbo_at_speed, pressure_equal, vacuum_ok"
2022-07-20T15:58:37.891 xcu_b3 d text="sending '~gStat,all\n'"
2022-07-20T15:58:37.896 xcu_b3 d text="recv '~gStat,all'"
2022-07-20T15:58:38.033 xcu_b3 d text="recv '11110100'"
2022-07-20T15:58:38.034 xcu_b3 i gatevalve=0xf4,closed,blocked;gvmask="0xcf";interlock=0b11110100,"open_cmd, turbo_at_speed, pressure_equal, vacuum_ok, gv_closed"```

 Comments   
Comment by cloomis [ 21/Jul/22 ]

The reported pressures are below 0. So the controller closes the valve when it sees the negative values with the valve open.

This is with 20191120-01

Comment by cloomis [ 14/Oct/22 ]

The code for 20191120-01 is clipping negative values to 0.0, but the corresponding image is clearly not doing so, per the attachment. In case the image had somehow been created/copied/installed incorrectly we made and tested a new one. No change, so Hope is looking at the code more closely.

Comment by cloomis [ 09/Nov/22 ]

Fixed – boiled down to a misunderstanding about non-standard (grr) PIC integer types.

In /software/firmware/interlock20221108-01.hex, which needs to be installed at Subaru and LAM.

[ I thought we had /software/firmware/ in a git repo but evidently not. ]

Generated at Tue Apr 08 19:32:07 JST 2025 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.