[INSTRM-1644] Provide PFI XML file loader to cobra_geometry tables Created: 20/Jun/22  Updated: 08/Dec/23  Resolved: 14/Sep/23

Status: Done
Project: Instrument control development
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: cloomis Assignee: chyan
Resolution: Done Votes: 0
Labels: EngRun, opDB
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks INSTRM-1643 Add "publish" script for PFI geometry Done
Sprint: Eng13Oct

 Description   

We need a loader for the cobra_geometry and cobra_geometry_calib_id tables, from a given PFI XML file.

As a reminder, the PfiDesign objects are fetchable given pfs_utils and ics_cobraCharmer. e.g.

cloomis@shell-ics:~$ setup pfs_utils
cloomis@shell-ics:~$ setup ics_cobraCharmer
cloomis@shell-ics:~$ python

In [1]: from pfs.utils import butler
In [2]: b = butler.Butler()
In [3]: pfi = b.get('moduleXml', moduleName='ALL', version='')

# Some of the essential fields:
In [5]: pfi.centers, pfi.L1, pfi.L2, pfi.tht0, pfi.tht1, pfi.phiIn, pfi.phiOut



 Comments   
Comment by Kiyoto Yabe [ 14/Jul/22 ]

The first implementation is in `ingestCobraGeometry.py`.

Currently, the time when the calibration was made is an input argument.

Is there any way to get the time from XML file automatically or should "publish" script take care of?

Comment by hassan [ 30/Nov/22 ]

Kiyoto Yabe what is the status of this ticket?

Comment by Kiyoto Yabe [ 30/Nov/22 ]

I believe the codes are there but haven't tested with the real system yet. We need to talk before the next run if this is still necessary.

Comment by hassan [ 08/Dec/22 ]

Is this still necessary Kiyoto Yabe or do you still need to discuss this?

Comment by chyan [ 25/Apr/23 ]

I personally tested the above code and it works. The butler will load the XML file. Since I am working on the new cobra geometry, I will take care of this ticket.

Comment by chyan [ 14/Sep/23 ]

cobra geometry inserted to DB.

Comment by chyan [ 08/Dec/23 ]

script tested and closed.

Generated at Sat Feb 10 16:37:53 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.