[INSTRM-1621] Update handling of bad fiducial fibres Created: 08/Jun/22 Updated: 13/Jun/22 Resolved: 13/Jun/22 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_mcsActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | karr | Assignee: | karr |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | PreEngRun06June |
| Description |
|
The handling of the bad fiducial fibres for the transformation function needs to be properly incorporated into the code. |
| Comments |
| Comment by karr [ 10/Jun/22 ] |
|
We do need to decide where to put the list of bad fiducial fibres; a yaml file in pfs_instdata or ics_mcsActor/etc would be easy to implement. |
| Comment by karr [ 12/Jun/22 ] |
|
I've updated the code, minus, tested on the live system and merged to master. Right now the outerRing IDs and bad fiducials are directly in the code; we can put them something more sensible at our leisure (ie, not critical for the run) |
| Comment by hassan [ 13/Jun/22 ] |
|
Marked as done as already merged to master. |