[INSTRM-1616] Returning 2394 locations from FibreID algorithm Created: 01/Jun/22 Updated: 12/Jun/22 Resolved: 12/Jun/22 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | chyan | Assignee: | karr |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Sprint: | PreEngRun06June | ||||||||||||
| Description |
|
Based on the design, the fibreID subroutine in mcsActor should return 2394 fiber positions. However, we found that fiberID only returns 2358 good cobras during May engineering run. Since the bad (or not-moving) cobras are still important as sky fibers, we still need to return their positions. |
| Comments |
| Comment by karr [ 08/Jun/22 ] |
|
The code has been updated, and needs a final test on the real system. Right now, for cobras with poor geometry, a fake arm length is used in order to interface with the fibreID code, and the position of the illuminated but stuck fibre is returned. For non-illuminated fibres, the dot position is returned (ie, the default for a hidden cobra spot). Updated geometry files improve the robustness of the results. |
| Comment by karr [ 12/Jun/22 ] |
|
Tested on live system and merged to master. |