[INSTRM-1613] Please provide an API to convert fiberId to cobraId Created: 19/May/22  Updated: 19/May/22  Resolved: 19/May/22

Status: Done
Project: Instrument control development
Component/s: pfs_utils
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: rhl
Resolution: Done Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks INSTRM-1612 We need to handle pfsDesign files tha... Done
Reviewers: arnaud.lefur

 Description   

pfsDesign files are written in terms of fiberId and the FPS needs to map these to cobraId (cf. INSTRM-1612).  The information is in the GrandFiberMap, but it would be better to provide an API to do the conversion and avoid the possibility of lurking bugs in more than one place.



 Comments   
Comment by rhl [ 19/May/22 ]

I added a fiberIdToCobraId method, which agrees with the more complete information provided by fiberIdToMTP (once I'd fixed an ordering bug in the latter)

Comment by rhl [ 19/May/22 ]

PR is https://github.com/Subaru-PFS/pfs_utils/pull/47

Comment by rhl [ 19/May/22 ]

Merged and pushed

Comment by hassan [ 19/May/22 ]

Ticket reviewed and changes merged to master.

Comment by arnaud.lefur [ 19/May/22 ]

tagged as 6.2.3 and installed at the summit

Generated at Sat Feb 10 16:37:34 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.