[INSTRM-1596] asking a wrong position of dcb filterwheel does not raise an error Created: 06/May/22  Updated: 10/Jun/22

Status: Open
Project: Instrument control development
Component/s: ics_dcbActor
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Normal
Reporter: fmadec Assignee: arnaud.lefur
Resolution: Unresolved Votes: 0
Labels: SPS
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

asking a wrong position of dcb filterwheel does not raise an error

so the sequence continue with an unknown filter wheel position

running an other cmd to the filterwheel will raise an error saying for wheel is not init

so it should raise an error at the first command saying smthg like "position does not exist"

 Comments   
Comment by arnaud.lefur [ 07/May/22 ]

Can you point me out which command should have failed ?
I looked at the logs briefly, and see set linewheel command with values in [2.0, 4.0, 12.7]
According to the config file, those positions are all valid :
qthHoles = none,0.7,1.0,2.0,4.0
lineHoles = 0.5,1.0,2.0,4.0,12.7

maybe the config file is wrong then ?

Comment by fmadec [ 09/May/22 ]

config is ok.
in a sequence (using sequencePanel) we can enter a wrong command for example 2 instead of 2.0 and this will not raise an error immediately

Comment by arnaud.lefur [ 09/May/22 ]

ah okay.
I actually did it on purpose, I though that 2 -> 2.0 was a clear enough translation.
I can easily remove that.

Comment by fmadec [ 09/May/22 ]

euh, well there is smgth wrong here
so I am confused now, so let me try to clarify what I saw.

I did run a sequence where there was a dcb set linewheel=2, no error was reported, but on the GUI, the wheel position was 'unknown" so the next sequence with also a dcb set linewheel smght failed.

so my point was that if the filterwheel position is unknown after a command it should raise an error.

let's try to reproduce that error (in fact errors because it happened several times)

Generated at Sat Feb 10 16:37:23 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.