[INSTRM-1574] Store disabled FF information Created: 09/Apr/22 Updated: 14/Sep/22 Resolved: 14/Sep/22 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | yuki.moritani | Assignee: | karr |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Story Points: | 2 | ||||||||||||
| Sprint: | preEngRun07Sep | ||||||||||||
| Description |
|
There are several FF disabled because the position is unstable and affects on accuracy/precision of the coordinate transformation. These position need to be stored either on pfs_insdata or on operation database, depending on how static they are. Like dot position ( By the way, where the ID and position of the broken FFs are stored at present? |
| Comments |
| Comment by chyan [ 29/Apr/22 ] |
|
According to the discussion in ICS/MCS meeting, we have create ticket |
| Comment by yuki.moritani [ 29/Apr/22 ] |
|
It is nice to have bit mask on opDB. Please confirm that FF status is dynamic? For example, Cobra status (disabled etc.) are stored in xml file, and the status are ingested to opDB too, arent' they? I' wonder if it is nice to have the same thing... |
| Comment by Kiyoto Yabe [ 01/Sep/22 ] |
|
Currently, the bit `mask` column is in `fiducial_fiber` table, which is basically static. `fiducial_fiber_geometry` is a more dynamic table, which can be updated every time we do measurement. So, I guess that bit mask should be in this table if the information persists in opDB. |
| Comment by karr [ 08/Sep/22 ] |
|
I've put the bad fibre information (as well as the indices out the outer ring fiducials that are used for the initial mask) in a yaml file in pfs_instdata, which is read using a routine in mcsRoutines/mcsRoutines.py. Code has been check to make sure the routines returns the same values as teh code previous in McsCmd.py Both ticket branches (pfs_instdata and ics_mcsActor) are tagged 1661, as there are two tickets related to this work.
|
| Comment by Kiyoto Yabe [ 09/Sep/22 ] |
|
According to the meeting with chyan, we need to think further about where `mask` should be in order to trace the history of the mask update. |
| Comment by karr [ 09/Sep/22 ] |
|
At the moment I have a yaml file; ultimately, I think incorporating it into the butler with a sequence of dated files and automatic read of the most recent would work best. (ie, the same way the geometry files/dot files are handled). |
| Comment by karr [ 14/Sep/22 ] |
|
branch 1661 of pfs_instdata merged to master (with the yaml file) |