[INSTRM-1569] Have ICC "finalize" pfsDesign on load. Created: 01/Apr/22  Updated: 02/Feb/23  Resolved: 02/Feb/23

Status: Won't Fix
Project: Instrument control development
Component/s: ics_iicActor
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: cloomis Assignee: cloomis
Resolution: Won't Fix Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to INSTRM-1609 Calculate fibre positions in mm just ... Done
relates to INSTRM-1570 Provide pfs_utils routine to finalize... Won't Fix
relates to INSTRM-1618 update opdb schema to cope with the n... Won't Fix
Sprint: PreEngRun05 G, PreEngRun06June

 Description   

pfsDesigns are generated for some sky position at some hour angle/altitude/airmass. When we use a design (nominally by gen2 calling iic moveToPfsDesign), we will know the actual altitude, and need to adjust the cobra positions to match. So iic should call some routine to do so.

We need a pfs_utils routine to finalize a pfsDesign given some altitude and iic needs to call it. That routine cannot change ra/decs (and thus the SHA).



 Comments   
Comment by yuki.moritani [ 08/Jul/22 ]

cloomis , rhl could you remind me again what is the relation with INSTRM-1609 ?  Is having "iic finalize pfsDesign" command still valid??

Comment by arnaud.lefur [ 02/Feb/23 ]

This still needs to be implemented, this will results in a pfsConfig.pfiNominal different from the pfsDesign.pfiNominal.
That's the final coordinate that we want to converge to, currently there aren't any columns in opdb to hold such information, so we'll need to add those.
Certainly in pfs_config_fiber table, something like :
pfs_config_fiber :

  • pfi_nominal_final_x_mm
  • pfi_nominal_final_y_mm
Comment by arnaud.lefur [ 02/Feb/23 ]

I don't know if you question still hold yuki.moritani, but I don't think we still an external command, fps should do this internally.

Comment by yuki.moritani [ 02/Feb/23 ]

Yes, it is also my understanding that fps will finalize the target positions. Then can we close this ticket, and arnaud.lefur could you file a ticket for final position in opdb, if we don't have one yet?

Comment by arnaud.lefur [ 02/Feb/23 ]

fps will do it internally, INSTRM-1852

Generated at Sat Feb 10 16:36:57 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.