[INSTRM-1551] Issue PFI-MCS coordinate transformations on bench Created: 16/Mar/22 Updated: 05/May/22 Resolved: 05/May/22 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | karr | Assignee: | karr |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Story Points: | 3 |
| Sprint: | PreEngRun05 F |
| Description |
|
When running the code offline to test the fibre identification, there appears to be an instability in the coordinate transformations, which causes issue in the calculation of cobra patrol regions. Below are examples from the sequence starting with frame 7209200, showing the transformed position of a non-moving cobra over a sequence of frames. The transformation is stable for most frames, but shows scatter in some frames, at up to a 0.6 mm scale. In addition, there is an offset of a few tens of mm between the transformed position and the true position of the fiducial fibres.
In addition, the production version of the code (6.1.3) produces different results than the version in the master branch on github, with the former being better. |
| Comments |
| Comment by karr [ 25/Mar/22 ] |
|
Follow up checking with Chi-Hung replicated the problem on the real system. We will check the effect of the unstable cobras.
|
| Comment by karr [ 31/Mar/22 ] |
|
Chi-Hung and I have confirmed that we get the same results. Removing unstable fiducial fibres improves the stability of the transform; the offset remains (on order of 0.2 mm). Chi-Hung has found that some sets of data are better than others; I'm exploring this now. |
| Comment by karr [ 01/Apr/22 ] |
|
The other thing I will check is looking at some of the data from the last engineering run, to see if the on-telescope transformation is better than the on-bench one.
|
| Comment by hassan [ 08/Apr/22 ] |
|
@karr will look at the offset issue in the coming week. |
| Comment by hassan [ 29/Apr/22 ] |
|
Additional plots needed and will then close out. |
| Comment by karr [ 05/May/22 ] |
|
|
| Comment by karr [ 05/May/22 ] |
|
Example of transformation residuals, above, version 6.1.3, below version 6.1.5 |
| Comment by karr [ 05/May/22 ] |
|
|