[INSTRM-1535] Determine (again) the places to store the dot position Created: 25/Feb/22  Updated: 08/Jul/22  Resolved: 08/Jul/22

Status: Done
Project: Instrument control development
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: yuki.moritani Assignee: Unassigned
Resolution: Done Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Sprint: PreEngRun06June

 Description   

Although we discussed the place to store the dot position (e.g. discussion related with INFRA-207), we re-visited this topic after the November run.
So far, dot position is stored under pfs_instdata, and the latest data contains spotId, x, y position in mm, and dot radius in mm.

I personally think the dot position should be stored on pfs_insdata for netflow/ETS.
What I think we need to discuss is whether we should store the information on opDB (and its schema). Considering that FF positions are stored on opDB as well as pfs_insdata, it should be stored on opDB for cobra movement. 

The data format on pfs_instdata should also be discussed... By the way, does spotId synchronize with cobraId?

 Comments   
Comment by hassan [ 01/Apr/22 ]

Following discussions during recent ICS/PFI telecons: We need to establish how stable the dot positions are before moving to {

{pfs_instdata}

}

Comment by hassan [ 01/Apr/22 ]

It has been agreed during today's ICS/PFI telecon that the data should be stored initially in pfs_instdata. If we find during the engineering runs that the data are unstable, they should be moved to opDB.

Comment by yuki.moritani [ 11/Jun/22 ]

As commented above, the dot position is stored in pfs_insdata:

https://github.com/Subaru-PFS/pfs_instdata/blob/master/data/pfi/dot/black_dots_mm.csv

Once the position is updated, the table will be stored here. The format is OK, but I'd propose to rename "spotId" to "dotId", because (1) we call the dots "dots", and (2) spotId is used by MCS centroid and might be confusing. 

Comment by hassan [ 11/Jun/22 ]

And there is a 1-1 mapping between dotId and cobraId, correct?

Comment by yuki.moritani [ 11/Jun/22 ]

Correct. Thank you for adding this.

Comment by yuki.moritani [ 08/Jul/22 ]

Since the latest measured position during the Jun run was uploaded to the above location, I close this ticket. (I defer column name issue... if needed this will be addressed with the new ticket)

Generated at Sat Feb 10 16:36:35 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.