[INSTRM-1529] comments on a PFSB sample file Created: 25/Feb/22  Updated: 29/May/23

Status: Open
Project: Instrument control development
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: monodera Assignee: cloomis
Resolution: Unresolved Votes: 0
Labels: FITS
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to INSTRM-1444 Issues in PFSA files (based on PFSA06... Done

 Description   

Subaru FITS committee looked at a sample PFSB file (PFJB02548123.fits). There are comments as follows. Comments provided in INSTRM-1444 are also applicable.

Misssing common keywords

  • BIN-FCT[1-2]
  • BLANK
  • BUNIT
  • DETECTOR
  • DET-TMP
  • EXP-ID
  • FRAMEID
  • GAIN

Missing Spectroscopy/Spectroscopy keywords

Note: listed for completeness - Subaru rule is being updated for MOS/fibre mode.

  • DISAXIS
  • DISPERSR
  • SLIT
  • SLITCPIX[1 -2]
  • SLIT-LEN
  • SLIT-PA
  • SLIT-WID
  • WAVELEN
  • WAVE-MAX
  • WAVE-MIN

Issues

Note: most of them have already discussed during the discussion on PFSA files.

  • WCS to be defined
  • default values for instrument & origin keywords such as TELESCOP, OBSERVAT, OBS-MOD to be checked
  • There are no time/temporal keywords in extension images. Is this acceptable?
  • EXPTIME exists only in primary HDU and no info for extension images. Is this acceptable? Comment is required. (EXPTIME=W_H4NRED*W_FRMTIM ?)
  • This file is not compressed. Is this a plan or will compression be enabled?
  • It is not clear what is in the 1st and 2nd extension, respectively (not exactly the FITS issue, though).
  • Do we plan to inclde additional HDUs per discussion on JIRA?
    1. RESET HDU for IRP files? (INSTRM-1336) plus a keyword for indicating the file storing/reading (e.g., IRP or not) mode?
    2. "at the end (summary) HDU" (DAMD-7) e.g., there is no direct info for NDR etc.
    seems to be without IRP so we have no REF HDUs, correct?
  • Formatting for float values should be checked.

Undefined basic keyword

  • RA_CMD, DEC_CMD --> _These will be added to the Subaru's FITS dictionary if it's necessary to include them in the header of PFS data._

other minor comments

  • MJD-STR = 59497.6215458 / [d] MJD at exposure start --> _%20.8f, but I guess it's provided by Gen2, and shorter length is okay if it's sufficient_
  • EXPTIME = 3257.115 --> _comment needed (it's defined as %20.2f, but seems to need this presision in [s]?)_


 Comments   
Comment by yuki.moritani [ 29/May/23 ]

Looking a FITS image during the April/May 2023 run, the following cards are missing to start Archive.

  • BIN-FCT1, BIN-FCT2
  • BUNIT
  • BLANK
  • GAIN (value is 9999)
  • OBSMODE (value seems to be fixed as "test")
  • The cards relating to WCS seems missing in reset frames
  • ADC-END (INSTRM-1871)
Generated at Sat Feb 10 16:36:32 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.