[INSTRM-1512] Add FPA arm name to motor number mapping Created: 25/Jan/22 Updated: 12/Sep/22 Resolved: 12/Sep/22 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_xcuActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | cloomis |
| Resolution: | Done | Votes: | 0 |
| Labels: | SPS | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The FPA arms are named A, B, and C. A is defined to be the arm which runs straight up (the visible cameras) or straight down (NIR). B and C are then defined to run clockwise from A. The motor controller uses motors 1, 2, and 3. The xcuActor was written assuming that arm A is driven by motor 1, etc. as it is for the visible cameras, but recent n1 work exposed that the NIR cameras have motor 1 at 02h00, or arm C. Arm A is motor 2 and Arm B is motor 3. In the tradeoff between wiring/documentation simplicity and code simplicity, we chose to change code. So add a mapping between arm names and physical motor ids, both forward and back. The ugly part is the MHS/archiver/header keywords. Regrettably, I used ccdMotorN and W_XMOT*N for the ones which describe the limit switches and positions. These are used in enough places and with enough history that I worry about redefining them. I think that the mapping should be entirely within the actor, effectively mapping the published "ccdMotor" 1,2,3 to an internal "controllerMotor" – 2,3,1 for the NIR, and 1,2,3 for the visible. |
| Comments |
| Comment by fmadec [ 26/Jan/22 ] |
|
ok, good to know! As soon as user can drive motor with A B and C we should be fine I think. one question clockwise looking from where ? (in front à la camera unit ? front of detector = looking to back to the camera?) |
| Comment by cloomis [ 12/Sep/22 ] |
|
Merged at 7faaf0b, tagged 2.1.0 |