Modify centroiding based on real data
(INSTRM-1471)
|
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_agccActor, pfs_instdata |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Sub-task | Priority: | Normal |
| Reporter: | karr | Assignee: | karr |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | PreEngRun05 B, PreEngRun05 C, PreEngRun05 D, PreEngRun05 E, PreEngRun05 F, preEngRun07Sep |
| Description |
|
The definition of the regions (overscan, two sides of images) should be moved to a configuration file in pfs_instdata, rather than being hardcoded. |
| Comments |
| Comment by karr [ 17/Dec/21 ] |
|
Created a yaml file which currently contains the boundaries of the useable region for the two sides of the image. There are separate entries for each camera. |
| Comment by karr [ 07/Jan/22 ] |
|
The yaml file contains a dictionary with fields cam1reg, cam2reg..., each of which is a list of the form [x1reg1,x2reg1,y1reg1,y2reg1,x1reg2,x2reg2,y1reg2,y2reg2] defining the region to be used for centroiding. A 0 indicates that the limit is the edge of the region. Further fields can be added if needed. |
| Comment by karr [ 13/Jan/22 ] |
|
Added a bad column field, and changed the format to a dictionary of six dictionaries labelled '1' '2' etc (easier to reference in code), with subfields 'reg' and 'badCols' in each, both of which are lists. The file still needs to be moved to its final location. |
| Comment by karr [ 13/Jan/22 ] |
|
Pushed to 1479 |
[INSTRM-1475]