[INSTRM-1462] Add clipping to geometry updated in PfiTransform Created: 18/Nov/21 Updated: 03/Feb/22 Resolved: 03/Feb/22 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | rhl |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Reviewers: | rhl |
| Description |
|
The PfiTransform.updateTransform method makes no attempt to clip bad matches and/or unstable fiducials. Please remedy this. |
| Comments |
| Comment by cloomis [ 22/Jan/22 ] |
|
This was never merged – does it need to be? |
| Comment by arnaud.lefur [ 03/Feb/22 ] |
|
I've created a pull a request. |
| Comment by cloomis [ 03/Feb/22 ] |
|
A couple of notes... This ticket fixes a significant bug. The branch was not merged during the engineering run. Instead, the tip of the ticket branch was tagged 6.1.4, and that is what we were running at the end of the run. Arnaud's rebase leaves that tag The "current" version at Subaru has since been reverted to 6.1.3 for work on the observing room floor. We should figure out what needs to be fixed so that we can incorporate this ticket and move forward. I did not see anything obvious. |
| Comment by cloomis [ 03/Feb/22 ] |
|
To be more specific, Arnaud will merge and close this ticket. When PFI operations are restarted we can clean up. |
| Comment by arnaud.lefur [ 03/Feb/22 ] |
|
merged as 6.1.5 |