[INSTRM-1446] Pass pfsConfig files to Gen2 Created: 14/Nov/21  Updated: 01/Mar/23  Resolved: 01/Mar/23

Status: Done
Project: Instrument control development
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: cloomis
Resolution: Done Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
is blocked by INSTRM-1863 Add a few FITS header to pfsConfig file Done
Sprint: PreEngRun4, PreEngRun10Feb

 Description   

We need to start thinking about how we send pfsConfig files to STARS.  In the short run, please pass all files to gen2 as soon as the cobra moves have finished.

If STARS would like to start accepting these files that would be fine with PFS, but we don't want to spend a lot of time convincing STARS that the file format is acceptable at this time.



 Comments   
Comment by cloomis [ 10/Feb/23 ]

The current files have been deemed acceptable as-is.

So adding a trigger for the iic.pfsConfig key, e.g. pfsconfig=0x2e772c5f91c219aa,86051,2023-02-09,100.000000,100.000000,0.000000,mergedSunSSAndDCB,0x0000000000000000,0 which will request that /data/raw/2023-02-09/pfsConfig/pfsConfig-0x2e772c5f91c219aa-086051.fits be archived.

Comment by cloomis [ 13/Feb/23 ]

Ticket parked for now: the MHS keyword is parsed and triggers some action. But archiving pfsConfig files via Gen2 will not work. We will need to either archive outside Gen2, or rename the files to, say, PFSE-{visit}00.fits. If we do that the frame allocator will need to request PFSE ids as well as the ones we already get. Not a big deal.

Comment by yuki.moritani [ 14/Feb/23 ]

Craig, Eric-san, Pyo-san and I had a meeting. Here is a notes:

  • Basically as long as the file format is FITS, we should follow the regulation
    • Name should be PFS{A-Z} {visit:06d}

      00.fits (Note, E, Q, Z are reserved.) -> we agreed to use "F"

    • Primary HDU should have important header cards (e.g. framId, proposal ID, observation datetime).
    • Since HIERARCH keys are not allowed by STARS/SMOKA, there may be a concern....
  • To archive pfsConfig file, PFS side can keep the name, and only need to send frameId and path.
  • Gen2 can rename the file to "PFSF{visit:06d}00.fits" on its side for archive to STARS/SMOKA.
    • A mechanism needs to be developed to use pfsConfig file by renaming again.
Comment by yuki.moritani [ 23/Feb/23 ]

Note from the result of 2023 February run (Run10)

  • pfsConfig files (PFSF*fits) were transferred to Gen2/STARS
  • PFSF*.fits passed verification on STARS, but failed to register, because some headers (namely, DATA-TYP, EQUINOX, RA2000, DEC2000, RADECSYS, WCS-ORIG) are missing. These cards are basically assumed the file is for the detector data.

We need discussions for archiving on STARS, but this is beyond of this ticket. 

Comment by rhl [ 23/Feb/23 ]

We should probably set DATA-TYP. We could set the others too, if empty/undefined (however FITS wants to specify that) is an allowed value.

If this is out of this ticket's scope (as it probably is), we should link the correct ticket to this one.

Comment by yuki.moritani [ 01/Mar/23 ]

As pfsConfig sent to Gen2, I close this ticket. The missing header cards will be handled with INSTRM-1875

Generated at Sat Feb 10 16:35:35 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.