[INSTRM-1444] Issues in PFSA files (based on PFSA06928311 and PFSA06928312) Created: 13/Nov/21 Updated: 23/Feb/23 Resolved: 23/Feb/23 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | EngRun |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | monodera | Assignee: | cloomis |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun, FITS | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Story Points: | 4 | ||||||||||||
| Sprint: | PreEngRun4, PreEngRun10Feb | ||||||||||||
| Description |
|
Furusawa-san and myself looked at PFSA06928311.fits and PFSA06928312.fits and found the following issues and concerns. I think that some may not be urgent for the November 2021 run and some require Subaru FITS committee to work on the observatory policy, but let me list all of them here. 1. Basic keywords in the primary HDU
Format issuesDEC, DEC2000 A12
2. Instrument keywords in the primary HDU
3. Queue-related keywordsThere are keywords for queue observations (https://www.naoj.org/Observing/fits/header/queue_keywords/). Not all of them are valid for PFS, but need to consider to put some of them. For example, OBS-MTHD, MOON-ILL, MOON-SEP, and MOON-EL will be helpful to distinguish the observing mode, but PROP-PI would not be appropriate as fibers are typically shared by multiple PIs. 4. Basic keywords in the first HDU
5. Missing spectroscopic keywords required by Subaru FITS regulation
SLIT = 'FIBRE-MOS' / Identifier of the entrance slit used SLT-LEN = 1.2 / Diameter of the fibre entrance (arcsec) SLT-WID = 1.2 / Diameter of the fibre entrance (arcsec) SLT-PA = 90 / Field position angle (degree) SLTCPIX1= 1024 / Slit center projected on detector (pixel) SLTCPIX2= 1024 / Slit center projected on detector (pixel) |
| Comments |
| Comment by naoyuki.tamura [ 14/Nov/21 ] |
|
I thought FITS committee would give us solid guidelines of how to populate such keywords in Section 5, so any inputs would be appreciated although, fundamentally, a regulation that requires "SLT"-related keywords for fiber-fed MOS is unreasonable, and therefore I know those in the keywords for FMOS were certainly placeholders.
|
| Comment by yuki.moritani [ 04/Dec/22 ] |
|
For recording: We received minimum list to archive PFS FITS file to STARS. The followings needs to be done to archive PFSA files (step 1 in the spreadsheet).
There are some to be addressed by science operation (step 2 in the spreadsheet). |
| Comment by cloomis [ 16/Dec/22 ] |
|
All but adding ADC-END are easy and done (ics_actorkeys 1.5.7, ics_utils 1.5.5, ics_ccdActor 1.8.10). For any gen2 card we want multiple values for (axis/rotator/adc/etc for PFSB reads, xxx-STR/xxx-END pairs for ADC, rotator, etc) I need to do some significant work: it does require a round trip call to the gen2Actor, but cannot at all block, ever. Can I take that particular card off this list for right now? It might not actually be that tricky to add, but adding a thread and cross-thread communication with timeout logic at that point will take some cruel testing, at least. |
| Comment by yuki.moritani [ 23/Feb/23 ] |
|
During the 2023 February run (run10), a few PFSA files are archived STARS, although not all the items discussed here are not cleared. I'm closing this ticket now to focus on the rest items more easily/clearly. The rest items are
|