[INSTRM-1440] Update mcs actor commands for cobra identification Created: 10/Nov/21  Updated: 18/Nov/21  Resolved: 18/Nov/21

Status: Done
Project: Instrument control development
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: karr Assignee: karr
Resolution: Done Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Story Points: 1
Sprint: PreEngRun4

 Description   

The calls to the fibre identification software need minor updates for the new transformation routines developed during the last engineering run.



 Comments   
Comment by karr [ 15/Nov/21 ]

A few changes made to update the centroiding and fibre identification based on changes made in the last engineering run. 

  • An optional switch cMethod to change method of centroiding during operation. default is 'win'
  • updated the fibre identification routine to use the new transformation object
  • removed / commented out a bunch of now obsolete code that was designed to test the process in the absence of mm units, real fiducial fibres, etc.
  • changed tranform -> transform in function name 
  • updated the threshold calculation to use the most recent boresight as an estimate of the centre of the field

The end result is simpler code.  There's probably still some non-critical tidying that can be taken care of later. 

Comment by karr [ 18/Nov/21 ]

rebased to master and pushed

Comment by karr [ 18/Nov/21 ]

Merged to master.

Generated at Sat Feb 10 16:35:31 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.