[INSTRM-1413] Update bore-sight calculation method in fpsActor Created: 22/Oct/21  Updated: 16/Nov/21  Resolved: 16/Nov/21

Status: Done
Project: Instrument control development
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: chyan Assignee: karr
Resolution: Done Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to INSTRM-1400 Implement boresight measurement routines Done
Story Points: 2
Sprint: PreEngRun4

 Comments   
Comment by hassan [ 02/Nov/21 ]

chyan can you provide a detailed description of the intended work please?

Comment by chyan [ 02/Nov/21 ]

A ticket branch is pushed to GitHub for addressing this ticket.  However, I noticed the implementation of INSTRM-1400 is not merged yet.  Also, the implementation in that ticket is a function call, it should be a MCS command expose to users. karr would you please update and merge INSTRM-1400?  

Comment by karr [ 02/Nov/21 ]

I checked and the boresight code is in master - the routines are in mcsRountes/mcsRoutines.py

Comment by karr [ 15/Nov/21 ]

I've updated the calculateBoresight routine in the fpsActor to match the call in IIC (firstFrame + lastFrame), and to call the MCS routine. It should work regardless of the frameId/visitId system (multiple visits, or a single visit with multiple frame numbers). 

 

Comment by hassan [ 15/Nov/21 ]

Changes look OK. Feel free to merge and close ticket karr.

Generated at Sat Feb 10 16:35:12 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.