[INSTRM-1406] Provide the measurement algorithm used for MCS spots in the opDB Created: 16/Oct/21  Updated: 18/Nov/21  Resolved: 18/Nov/21

Status: Done
Project: Instrument control development
Component/s: spt_operational_database
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: hassan Assignee: Kiyoto Yabe
Resolution: Done Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks INSTRM-1430 update mcs for new database columns Done
Relates
relates to INSTRM-1405 Provide the measurement algorithm use... Done
Story Points: 2
Sprint: PreEngRun4, EngRun3Cleanup
Reviewers: hassan

 Description   

Similarly to INSTRM-1405: it appears that the algorithm used to measure MCS spots is not written to the opDB.

Please add a new column to the mcs_exposure table to specify the algorithm used.

 Comments   
Comment by Kiyoto Yabe [ 28/Oct/21 ]

I add a new column `measurement_algorithm` in `mcs_exposure` table. 

    measurement_algorithm = Column(String, comment='Spot measurement algorithm (fast/slow)')

I'm assuming that we only have `fast` and `slow` according to INSTRM-1412, but is this OK, karr Yoshida, Hiroshige ?

Comment by rhl [ 29/Oct/21 ]

We'll need to be able to use these keywords to get back to an algorithm in GitHub. The SHA1 needn't be provided, of course, as we'll be tracking the MCS code versions. If there are additional important configuration parameters, we'll need to track them too.

Comment by rhl [ 29/Oct/21 ]

Isn't INSTRM-1412 about the AGCC? This ticket is about the MCS. Were you thinking of INSTRM-1405?

Comment by Kiyoto Yabe [ 29/Oct/21 ]

I thought it was the same in MCS, but maybe not. 

Comment by rhl [ 29/Oct/21 ]

I think we should treat the two algorithms as different (even if they are currently coincidentally the same).

Comment by karr [ 02/Nov/21 ]

The code for the two actors is currently separate, so it makes sense to have columns in both mcs_data and agcc_data, which currently have the same possible values but which could change in the future. 

Comment by Kiyoto Yabe [ 11/Nov/21 ]

One small question: do we need the column in `_data` table? I thought the algorithm is the same for all spots per exposure if we choose one algorithm, so I though it is sufficient to have the column in `_exposure` table.

Comment by Kiyoto Yabe [ 17/Nov/21 ]

The same as INSTRM-1405. I have pushed the current changes. Could you review that if possible?

Comment by karr [ 17/Nov/21 ]

The column for centroid method looks good to me. 

Comment by hassan [ 17/Nov/21 ]

Changes also look fine to me.

Comment by Kiyoto Yabe [ 18/Nov/21 ]

merged

Generated at Sat Feb 10 16:35:08 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.