[INSTRM-1402] update the transforms and make the pfi <--> mcs transforms exactly round trip Created: 16/Oct/21 Updated: 12/Nov/21 Resolved: 12/Nov/21 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | yuki.moritani | Assignee: | yuki.moritani |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 4 |
| Sprint: | PreEngRun4, EngRun3Cleanup |
| Description |
|
At present, pfi-to-mcs transform only covers scale conversion. During the September run we found that we need to fully cover distortion so that pfi<->mcs transform is round trip. |
| Comments |
| Comment by yuki.moritani [ 27/Oct/21 ] |
|
I've started to getting the coefficients for both transformation using spot calculation by Subaru engineer. As I found something with the data, we are talking about calculation with her now, which will take a time. |
| Comment by yuki.moritani [ 02/Nov/21 ] |
|
I updated the code to ticket branch. When I ran the code, the difference between the original PFI position and round-tripped PFI position is several um (at most) in the case of EL=90, no ADC movement, and ~50um (at most) in the other cases. The error in other cases comes from pfi->mcs transformation. (At present, error of a half pixel remains.) I need to think about better solution, but if it can be done another ticket, I'll merge this branch for now. |
| Comment by yuki.moritani [ 12/Nov/21 ] |
|
Following conversations at the commissioning telecon on 10-11 Nov 2021, I merged the branch to master and close this. Analysis with Top-level utilities will be done separately. |