[INSTRM-1394] Update PFI-MCS transformation tables on opDB Created: 12/Oct/21 Updated: 16/Sep/22 Resolved: 15/Sep/22 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | spt_operational_database |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | hassan | Assignee: | karr |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Story Points: | 2 | ||||||||||||||||
| Sprint: | PreEngRun05 F, preEngRun07Sep | ||||||||||||||||
| Description |
|
In relation to This ticket should be addressed once we know the degrees of freedom of the needed transformation updates. |
| Comments |
| Comment by chyan [ 17/Dec/21 ] |
|
I just reported another issue to Robert in the meeting last time. There are inconsistency between the matched table location and location transformed from pixel coordinated. I guess there are some book keeping issue and I would need Robert's advice. |
| Comment by chyan [ 11/Feb/22 ] |
|
There is a upgrade of pfs_utils to 6.1.5. We should test this to see if the problem solved. |
| Comment by hassan [ 02/Jun/22 ] |
|
chyan what is the status of this work? |
| Comment by hassan [ 15/Jul/22 ] |
|
Transformations seem to be working well. karr to confirm with RHL whether the PFI-MCS transformations are sufficiently stable, so need to firm down the definitions of the coefficients. |
| Comment by karr [ 26/Aug/22 ] |
|
Robert has confirmed that the transformation is stable, so I can proceed with this. |
| Comment by karr [ 08/Sep/22 ] |
|
Updated write statements have been added to ics_mcsActor, and a matching scheme to a branch in spt_operation_database. The necessary parameters are passed back as part of the transform object, so the transform code doesn't need any modifications. I am confirming the format with Robert (so I haven't missed anything that should be written). |
| Comment by Kiyoto Yabe [ 08/Sep/22 ] |
|
OK, so after you confirm that the format is OK, please make a pull request. I'll review that and merge. Thanks. |
| Comment by Kiyoto Yabe [ 14/Sep/22 ] |
|
karr Any update on confirming the format? |
| Comment by karr [ 14/Sep/22 ] |
|
I've created the pull request. Once the database schema is updated, I can merge the ics_mcsActor part of the code. |
| Comment by Kiyoto Yabe [ 15/Sep/22 ] |
|
Thank you, karr ! One small thing is that I guess we use `camera_name` to distinguish MCS and 71M for the past data, but we already have `mcs_camera_name` in `mcs_camera` table and `mcs_camera_id` is in `mcs_exposure` table. Do we still need a similar column in this table? |
| Comment by Kiyoto Yabe [ 15/Sep/22 ] |
|
This was merged and closed. |
| Comment by karr [ 15/Sep/22 ] |
|
ics_mcsActor changes pushed to master as well. |
| Comment by Kiyoto Yabe [ 16/Sep/22 ] |
|
Oh, I closed the ticket before mcsActor changes are merged. Apologies... |