[INSTRM-1393] PfiTransform should write updated transformation coefficients to opDB Created: 12/Oct/21  Updated: 02/Sep/22  Resolved: 15/Jul/22

Status: Won't Fix
Project: Instrument control development
Component/s: pfs_utils
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: hassan Assignee: chyan
Resolution: Won't Fix Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to INSTRM-1394 Update PFI-MCS transformation tables ... Done
Story Points: 2
Sprint: PreEngRun4, EngRun3Cleanup, preEngRun07Sep

 Description   

The PfiTransform.updateTransform() method should after establishing the revised transform coefficients, write those coefficients to the opDB.



 Comments   
Comment by rhl [ 29/Oct/21 ]

We may want to postpone this until after INSTRM-1402 is complete and we have a better idea of the needed coefficients. However, it's probably safe to assume that we'll need at least dx, dy, dtheta, a, b where the radial scale is 1 + a + b r^2

Comment by chyan [ 16/Nov/21 ]

There is a table called camera_model_f3c_mcs.  I think that is the good place for storing all those coefficients.

Comment by hassan [ 22/Dec/21 ]

rhl cloomis Kiyoto Yabe yuki.moritani Question: are the distortion parameters static? If so should they be written to the opDB or to pfs_instdata?
If the former, the next step is to check with Kiyoto Yabe whether the camera_model_f3c_mcs is the correct table, whether it requires a schema update, or whether a different table should be used.

If these coefficients are static, a location under pfs_instdata needs to be agreed.

Finally, the distortion parameters may be a function of elevation and instrument rotator angle, so a more general means of modeling the distortion parameters may need to be considered.

Comment by yuki.moritani [ 22/Dec/21 ]

I personally think coefficients that Robert raised are expected to be dynamic..?

Comment by hassan [ 23/Dec/21 ]

Following discussions during the ICS/PFI telecon 2021-12-23:

1. the transformations are dynamic.
2. More information is needed before this work can commence. And yuki.moritani needs to think more about the coordinate transformations.

This ticket will be rescheduled to a later sprint.

Comment by hassan [ 15/Jul/22 ]

Closing this ticket. Work is being addressed in INSTRM-1394.

Generated at Sat Feb 10 16:35:00 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.