[INSTRM-1389] Store the MCS camera used in the opDB Created: 11/Oct/21  Updated: 05/Nov/21  Resolved: 05/Nov/21

Status: Done
Project: Instrument control development
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: hassan Assignee: Kiyoto Yabe
Resolution: Done Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to INSTRM-1390 Create PfiTransform instance based on... Done
Story Points: 1
Sprint: PreEngRun4, EngRun3Cleanup
Reviewers: hassan

 Description   

Quoting rhl in his email 2021-11-07:

Do we have the book-keeping in opdb to know which camera we are using? It looks as if a string field for "MCS" or "71M" should be added to the mcs_exposure table.



 Comments   
Comment by Kiyoto Yabe [ 26/Oct/21 ]

Although there might be two cameras (so far), I'm proposing to create a new table `mcs_camera` table for MCS camera id. I'm thinking that id=0 for MCS and 1 for 71M, which will be stored in `mcs_exposure` as well. Any comments are welcome.

class mcs_camera(Base):
    __tablename__ = 'mcs_camera'

    mcs_camera_id = Column(Integer, primary_key=True, autoincrement=False,
                           comment='MCS camera identifier [0=MCS, 1=71M]')
    mcs_camera_name = Column(String,
                             comment='MCS camera name [e.g. "MCS", "71M"]')
    comments = Column(String)

    def __init__(self, mcs_camera_id, mcs_camera_name,
                 comments):
        self.mcs_camera_id = mcs_camera_id
        self.mcs_camera_name = mcs_camera_name
        self.comments = comments
 

 

Comment by Kiyoto Yabe [ 27/Oct/21 ]

I'm not sure who should be the reviewer but feel free to re-assign.

Comment by hassan [ 28/Oct/21 ]

No objections with the proposed new table.

Related to that, there is a discussion in the #pfi-ics slack channel today, in which the camera names would be rmod_71M and canon_mcs.

Comment by Kiyoto Yabe [ 05/Nov/21 ]

merged and closed

Generated at Sat Feb 10 16:34:56 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.