[INSTRM-1348] Ingest pfsDesign/pfsConfig files to opDB Created: 03/Sep/21  Updated: 14/Apr/22  Resolved: 01/Apr/22

Status: Done
Project: Instrument control development
Component/s: spt_operational_database
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Kiyoto Yabe Assignee: Kiyoto Yabe
Resolution: Done Votes: 0
Labels: EngRun, opDB
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks INSTRM-1338 Have fpsActor read proper pfsDesign f... Done
is blocked by INSTRM-1352 Some fix and cleanups of `pfsDesign` ... Done
Relates
relates to INSTRM-1577 Verify the mechanism to store pfsDesi... Done
relates to DAMD-120 Add designName to pfsDesign header? Done
relates to INSTRM-1427 Publish pfsConfig files when the PFI ... Done
relates to INSTRM-1437 Add `design_name` in `pfs_design` table Done
relates to INSTRM-1379 Integrate agccActor to opDB Won't Fix
relates to INSTRM-1143 Add a tool to ingest data from pfsDes... Done
relates to INSTRM-1278 Add commands to generate complete pfs... Won't Fix
Story Points: 3
Sprint: PreEngRun4

 Description   

Per discussion with hassan, we file a separate ticket regarding the opDB I/O for INSTRM-1278. The task of this ticket is to write and test (example) codes to ingest `pfsDesign/pfsConfig` files (or DataFrames from INSTRM-1278) to opDB and read necessary information for those tables. We actually had INSTRM-1143, which has been already closed, but this ticket handles a complete set of `pfsDesign` file with the latest datamodel (e.g., guidestars HDU).

 Comments   
Comment by rhl [ 28/Oct/21 ]

I don't think we need this as part of the post-Sept run, but we do need it for November.  I propose that we remove it from the  EngRun3Cleanup sprint

 

Comment by hassan [ 28/Oct/21 ]

Now moved to PreEngRun4 sprint.

Comment by hassan [ 05/Nov/21 ]

Kiyoto Yabe: following DAMD-120, you will need to add designName to the schema I believe.

Comment by Kiyoto Yabe [ 05/Nov/21 ]

I have filed a separate ticket for this.

Comment by hassan [ 09/Nov/21 ]

Kiyoto Yabe: as part of this work, will you provide a routine which takes a pfsDesign/pfsConfig and populates the opDB tables? That way, INSTRM-1427 can use that to write directly to the opDB.

If that work is needed to be in a separate ticket, I can file that.

Comment by Kiyoto Yabe [ 11/Nov/21 ]

Should that routine be in `pfs_utils` or `spt_operational_database`?

Comment by hassan [ 11/Nov/21 ]

I would say pfs_utils. cloomis, arnaud.lefur?

Comment by cloomis [ 11/Nov/21 ]

pfs_utils , yes.

Comment by Kiyoto Yabe [ 19/Nov/21 ]

I pushed the routine to `pfs_utils`.  Another question: can we get timestamps (designed/configured) from pfsDesign/pfsConfig object?

Comment by hassan [ 31/Mar/22 ]

Kiyoto Yabe can we close this ticket now? Or what additional work is needed to complete this?

Comment by Kiyoto Yabe [ 31/Mar/22 ]

I was thinking that this would be verified in the next engineering run. The implementation was completed (I guess) but we couldn't test that in Nov. In opDB side, the change has been merged, but not in `pfs_util` side yet. Should I close this ticket with the one at this moment and file another ticket for the next engineering run?

Comment by hassan [ 01/Apr/22 ]

Hi Kiyoto Yabe yes, that sounds like a good proposal. Please close this ticket and file a new one.

Comment by Kiyoto Yabe [ 01/Apr/22 ]

OK, I have merged the change on `pfs_utils`. I'll file a ticket to verify the implementation.

Generated at Sat Feb 10 16:34:26 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.