[INSTRM-1337] Move matching code from fps to mcs, and allow switching matching implementations. Created: 05/Aug/21 Updated: 15/Oct/21 Resolved: 15/Oct/21 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_cobraCharmer, ics_fpsActor, ics_mcsActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | chyan |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun, PFI | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 2 | ||||||||
| Sprint: | EngRun03 | ||||||||
| Description |
|
The spot-to-fiber matching is currently done on the fps side. We have two matching algorithms (the simple cobraCharmer one, and the functions in the mcsActor), and would like to be able to compare them. Besides that, we have agreed on a cobra_match table to hold the match data. So the fps-based match code can and should be moved to the mcsActor. |
| Comments |
| Comment by cloomis [ 20/Sep/21 ] |
|
And the code on the ics_fpsActor side should be removed, so that we do not accidentally call it. |
| Comment by chyan [ 04/Oct/21 ] |
|
All the matching is now happened in ics_mcsActor, so this ticket should be closed. |
| Comment by hassan [ 15/Oct/21 ] |
|
During a ticket review 2021-10-14 chyan confirms this is complete. |