It appears that significant improvements were made to context manager support between sqlalchemy 1.3.something and 1.4.something – that link does not apply to 1.3. We are running 1.3.20 at Subaru.

The update would be clean (per mamba update sqalchemy, only sqlalchemy and greenlet would be touched).

If people are nervous we could clone the conda-ics environment and update that for testing. I'm running one now and will report back.

[ Note: mamba update --dry-run sqlalchemy took 15s and offered the current 1.4.21; conda update --dry-run sqlalchemy took 5 minutes and only offered 1.4.4. Both using the same repos. Someone's solver is wrong. ]

I have run sqlalchemy 1.4.21 in a test conda environment for MCS testing, and it did not obviously break anything in mcs or fps. Can I update the version in conda-ics?

I just updated the version and tested in my side and did not see any problems so far, so I think you can updete on the mountain.

Thanks. Done (actually, 1.4.22). I believe the following idiom (from the linked document) for the Opdb class should now work:

# we can now construct a Session() and include begin()/commit()/rollback()
# at once
with self.session.begin() as session:
    session.add(some_object)
    session.add(some_other_object)
# commits the transaction, closes the session

I pushed a test implementation like this on the branch, but not sure if it's a right way so need a review.

def insert(self, tablename, dataframe):  
    model = getattr(models, tablename)
    with self.session.begin() as s:
        s.session.bulk_insert_mappings(model, dataframe.to_dict(orient="records"))

Can we close this ticket? If the current opDB codes (at the summit) deal with this properly, I will check them and try to make them merged.

Kiyoto Yabe I think all opDB code (as well as other software) at the summit needs to be merged to master. So we should best close this ticket after the merge.

I think now the current master branch is (almost) compatible with the summit change. Could somebody check at summit whether it works as we expected?

I did the most I could.
I haven't tested yet, but I've mostly followed sqlalchemy prescription

arnaud.lefur is there any quick test you could do to close this ticket?