[INSTRM-1320] Unify FPS code formatting Created: 12/Jul/21 Updated: 23/Feb/23 Resolved: 23/Feb/23 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_cobraCharmer, ics_fpsActor, ics_mcsActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | cloomis |
| Resolution: | Done | Votes: | 0 |
| Labels: | PFI | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Apply black -l 110 -S to all python code in the three FPS packages. Not really what we want to do (black is a crude and ugly tool), but there is just too much variability in the code formatting. |
| Comments |
| Comment by cloomis [ 13/Jul/21 ] |
|
Like most other projects we require basic PEP8 compliance. So instead of black I ran the gentler autopep8, using the recommended LSST invocation: autopep8 --ignore E133,E226,E228,E266,N802,N803,N806,W503 --max-line-length 110. That resulted in fewer disturbing rewrites. Merged to ics_cobraCoach, ics_mcsActor, ics_fpsActor. We should try to keep the code from diverging again. n.b. The LSST Developer guide discusses PEP8, etc. and has recommendations for configuring emacs/Sublime/vim/VS Code. PFS is not LSST, but we do share some development. |
| Comment by yuki.moritani [ 23/Feb/23 ] |
|
It was conformed this was done at the ASIAA meeting |