[INSTRM-1281] move device/instrument configuration into a single repo. Created: 21/May/21  Updated: 05/Oct/22  Resolved: 05/Oct/22

Status: Done
Project: Instrument control development
Component/s: ics_enuActor
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: arnaud.lefur Assignee: arnaud.lefur
Resolution: Done Votes: 0
Labels: SPS
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates INSTRM-119 Move device configuration into ics_co... Won't Fix
Relates
relates to INSTRM-1485 add actor config to the current instD... Done
relates to INSTRM-1552 Have Actor/ICC load from pfs_instdata... Done
Story Points: 3
Sprint: SM1PD-2021 A10, SM1PD-2021 A 11, SM1PD-2021 A 12, SM1PD-2021 A 13, SM1PD-2021 A 14

 Description   

I'm reviving that subject following the discussion with cloomis today.
I think we manage to distinguish our needs and expectations, I will be trying to rephrase it here to avoid further confusions. I'm going to start with what we currently have :

  • a per actor configuration file in $ICS_ACTOR_DIR/etc/
  • InstData class in pfs_utils to persist/load mhs keywords to/from disk.

What we want is to move as much information as possible for the etc file to a common repo.
yaml is very likely to be right choice, so that we can factorize configuration shared among identical module/unit and specify per-instance dedicated values.
This/these file(s) are edited/written by human in most (all?) cases.

The persistence mechanism is completely machine-oriented, it's read and written by a program.
It can be seen as an instrument snapshot, so that some variable/state can be reloaded if needed for instance after :

  • software reboot
  • some power cycle
  • temporary hardware issue...

Those two mechanisms are actually different and so their time constant.
I hope it clarifies the big picture.



 Comments   
Comment by cloomis [ 18/Mar/22 ]

We have been moving forward with the actor configuration part of this, putting per-actor ("enu", not "enu-sm2") yaml files in $PFS_INSTDATA/config/actors/.

Replacing the last part of the per actor ("enu-sm2", not "enu") .cfg files will require a change to tron_actorcore itself, since that is what sets up the connections to the tron hub and the actor logging. See

Comment by arnaud.lefur [ 05/Oct/22 ]

all API has been implemented in pfs_instdata/ics_utils and available now in tron_actorcore.
it's now up to each actor to use it and get rid of the old etc/configParser file.

Generated at Sat Feb 10 16:33:45 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.