[INSTRM-1276] Update mcsActor with fibreID routine and database interation Created: 17/May/21  Updated: 15/Oct/21  Resolved: 15/Oct/21

Status: Done
Project: Instrument control development
Component/s: ics_mcsActor, spt_operational_database
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: karr Assignee: karr
Resolution: Done Votes: 0
Labels: EngRun, PFI
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
is blocked by INSTRM-1322 Updated fibreID routine for mcsActor Done
Story Points: 2
Sprint: EngRun03

 Description   

Update the mcsActor with database integration, and full sequence of commands.



 Comments   
Comment by karr [ 21/May/21 ]

The current code now runs on the ASRD computer using simulated images. 

Comment by Kiyoto Yabe [ 24/May/21 ]

Thank you for the update! A couple of questions:

  • The values seem to be in pix. Is this fixed once the coordinate transformation issue is resolved?
  • `pfi_nominal_x/y_mm` changes with iteration, but I thought it was the final destination after all iterations so didn't change, instead `pfi_target_x/y_mm` increases with iteration. Am I mis-understanding? Maybe naming of the column is bad.
  • Are other columns such as step size and on-time also going to be populated?
  • In `cobra_match` table, there seem to be records for only interation=1, are you also going to pupulate it for other iteration?
Comment by karr [ 25/May/21 ]

Thanks for the comments. In answer,

  • I added a switch for fibre input methods, which will toggle between asrd (pixels, no transforms, XML file geometry), commissioning data (full transformations, fake fiducial fibres, no cobra movement), and the real case. For the last case, we need the transformations, geometry files and FF coordinates in mm and FF exposures. The switch itself can probably be removed once everything is in place.
  • that will be my mistake, I'll change the variable names
  • yes, but by the fps actor. For testing, I made fake database entries for the pfs_visit (and fiducial_fiber tables when needed), and manually populated the mcs_exposure table. In full operation the former will be populated before the mcs actor is called, and the mcs_exposure will be populated when the exposure is taken. I don't know the status of those parts.
  • yes, the current population was for testing purposes, and I was writing/deleting entries repeatedly as I ran the tests.  
Comment by hassan [ 19/Aug/21 ]

karr: what's the status of this ticket? Are you using the opDB now for your interactions?

Comment by hassan [ 15/Oct/21 ]

During a ticket review 2021-10-14 @jkarr reports this has being complete.

Generated at Sat Feb 10 16:33:42 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.