[INSTRM-1266] VisitID and FrameID name convention of MCS-FPS interaction Created: 07/May/21  Updated: 03/Aug/21  Resolved: 03/Aug/21

Status: Done
Project: Instrument control development
Component/s: ics_fpsActor, ics_mcsActor
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: chyan Assignee: cloomis
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The FPS actor now calls the MCS actor to do exposure. However, the image name generated by MCS is not following the convention f'PFSC

{VisitID} {FrameID}

.fits'.



 Comments   
Comment by chyan [ 07/May/21 ]

Looking down to the MCS actor, the file name is given by the getNextFilename function. This function calls gen2Actor in line 218.

Comment by cloomis [ 07/May/21 ]

This needs to be changed for Subaru:

  • iic gets the visit from gen2
  • iic sends visit= to fps for all the top-level commands (motor maps, convergence, etc.). iic already does that for SPS, btw.
  • iic sends visit= and frame= down to mcs for each exposure.

getNextFilename is only for standalone testing.

Comment by cloomis [ 07/May/21 ]

This is actually slightly more involved than I stated. Because it is so informative to group data by action (motor map, convergence), cobraCharmer has been creating a directory for each of these, with subdirectories for PFxC and stack files, logs, and output files (.xml and the file versions of the opdb tables, mainly).

I think we should continue doing this. Which essentially boils down to telling the mcsActor where to save the PFxC files. For now I propose being explicit (path=/data/raw/$date/fps/$runName), though we could also send the name of theĀ "run directory" (run=$runName) and use a/the butler to instantiate the file path.

Comment by cloomis [ 13/Jul/21 ]

I was wrong. Mcs should dumbly save PFxC files in /data/raw/mcs. They partition into runs nicely by visit. Fps can make structured directories separately, and can have symbolic links to the read data files.

We might want to add mcs commands to control the generation of the very useful stack image files – with 100 Mpix cameras it does pay to avoid round trips to disk over the network.

Comment by cloomis [ 03/Aug/21 ]

Basics done. Depends on unmerged opdb changes.

Merged at a2bb35a, tagged 1.5.0

Generated at Sat Feb 10 16:33:36 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.