[INSTRM-1242] Add black spot geometry interface Created: 16/Apr/21  Updated: 21/Oct/21  Resolved: 21/Oct/21

Status: Done
Project: Instrument control development
Component/s: pfs_utils
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: cloomis Assignee: chyan
Resolution: Done Votes: 0
Labels: EngRun, PFI
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by INSTRM-1339 Provide function to provide PFI black... Won't Fix
Relates
relates to INSTRM-1244 Put all data interfaces used for targ... Open
Story Points: 3
Sprint: EngRun3Cleanup
Reviewers: hassan

 Description   

The geometry of the black spots will be added to some pfs_instdata data file. Add a functional interface in pfs_utils.

This geometry should be in mm in the PFI focal plane. For each spot we need to know:

  • ID (presumably the ID for the cobra that can reach that spot)
  • centre (x, y)
  • radius r1 where the spot starts to shadow the cobra
  • radius r2 where the cobra is fully shadowed

Initially, we can set r1 and r2 to be the same.

Additionally, the centre (x, y) is thought to be a function of telescope elevation (we think that it does not depend on the PFI rotation angle). So we need an API which returns a data structure (say SpotGeom) capturing these parameters, and an API to return either a
single SpotGeom or a list or dict of SpotGeom for all the spots. If the ID is a simple integer then the list can be indexed by that integer (with a None for any missing IDs, which is probably only 0). If we're using a more complicated name, then return a dict.

 Comments   
Comment by hassan [ 06/Aug/21 ]

[Copying from duplicate ticket INSTRM-1339]: This function should make use (interpolate) the CSV files located here: https://github.com/Subaru-PFS/pfs_instdata/blob/master/data/pfi/dot

Comment by hassan [ 06/Aug/21 ]

Updated description mentions that : 'radius r2 where the spot is fully shadowed' Shouldn't this say 'radius r2 where the cobra is fully shadowed' ? Done.

Comment by chyan [ 05/Oct/21 ]

Currently, the dot location is in a file. There is an implementation using bulter.py package for the IO. Check line 152 in ics_cobraCharmer/python/ics/cobraCharmer/utils/bulter.py

Comment by hassan [ 15/Oct/21 ]

During a ticket review 2021-10-14: need to check with cloomis whether all functionality needed for this ticket has been implemented already.

Comment by chyan [ 21/Oct/21 ]

The dot file is located in '/software/devel/pfs/pfs_instdata/data/pfi/dot/black_dots_mm.csv' and I think this is also agreed by Robert. So I would close this ticket.

Generated at Sat Feb 10 16:33:20 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.