[INSTRM-1231] Sanitize FITS headers before sending to fitsio. Created: 08/Apr/21 Updated: 22/Jul/21 |
|
| Status: | Open |
| Project: | Instrument control development |
| Component/s: | ics_ccdActor, tron_actorcore |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | cloomis |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | FITS | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 1 |
| Description |
|
The camera actors are pretty careful about catching errors while constructing headers, but we should run a pass over the header to pick up any stray problems we can think of: fitsio evidently blows up without writing the data if there are certain problems. Specifically: look for "NaNs", scream, and replace them with the Official NAOJ Invalid Value: 9998.0. Will handle the currently failing conversion elsewhere, but I think we will always be prone to this really catastrophic failure: NaNs are good at leaking. |
| Comments |
| Comment by cloomis [ 08/Apr/21 ] |
|
Will also file a request with Sheldon: there is a clean place for invalid values to be caught when FITSHDRs are constructed. Those cannot be fixed, since FITS has no NaN support in headers. But could avoid fatal errors being found too late. |