[INSTRM-1229] Sort out current `cobra_status` & `cobra_movement` Created: 07/Apr/21  Updated: 16/Apr/21  Resolved: 16/Apr/21

Status: Done
Project: Instrument control development
Component/s: spt_operational_database
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major
Reporter: Kiyoto Yabe Assignee: Kiyoto Yabe
Resolution: Done Votes: 0
Labels: opDB
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PDF File opdb_cobra_tables_rev1.pdf     PDF File opdb_cobra_tables_rev2.pdf    

 Description   

Update both tables per discussion of the last phonecon. Rename `cobra_movement` to e.g. `cobra_target` which also includes target position in mm and flag for collision etc. Rename `cobra_status` to e.g. `cobra_matched` which includes matched information from mcs data.



 Comments   
Comment by Kiyoto Yabe [ 11/Apr/21 ]

The initial fix can be found in the branch.

`cobra_target` (previously `cobra_movement`) includes cobra targeting values such as the target positions and step size of each cobra in each iteration. `cobra_matching` (previously `cobra_status`) covers the matched position of spots on the MCS image. I just revert onto `pfi_nominal_[xy]_mm` as the final cobra destination, which is consistent with the datamodel.

Anyway, any feedback regarding structure, naming, additional columns is all welcome. chyan karr cloomis hassan ?

Attached below is the zoom-in diagram for the related tables:

opdb_cobra_tables_rev1.pdf

Comment by cloomis [ 14/Apr/21 ]

Some thoughts:

  • having cobra_target key on mcs_frame_id bothers me: the cobra_target row will be inserted before the mcs exposure is taken. And the cobra_target table is filled by a completely separate actor (fps) from the mcs_exposure table (mcs).
  • should cobra_matching link to cobra_target and drop the "nominal" fields?
  • the cobra_matching table needs a flags field.
  • the cobra_target table should have target angles as well as (x, y) and (step, ontime).
  • should there be two motor_calib_ids and should they actually be cobra_motor_model_ids?
  • I think I would rename "cobra_matching" to "cobra_match", maybe?
Comment by Kiyoto Yabe [ 15/Apr/21 ]

This is the second revision, which is a hasty fix so may be something wrong. Anyway, let's talk about this at the phonecon tomorrow.

opdb_cobra_tables_rev2.pdf

Generated at Sat Feb 10 16:33:12 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.