[INSTRM-1162] add a command and keyword to declare DCB pupil mask size Created: 18/Jan/21 Updated: 12/Feb/21 Resolved: 12/Feb/21 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_dcbActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | arnaud.lefur | Assignee: | arnaud.lefur |
| Resolution: | Done | Votes: | 0 |
| Labels: | SPS | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 1 | ||||||||
| Sprint: | SM1PD-2021 A 2 | ||||||||
| Description |
|
As it has an important effect on the data, we need to track this as mhs and FITS keyword. |
| Comments |
| Comment by rhl [ 19/Jan/21 ] |
|
I think that a new mask should probably change the pfsDesignId too. |
| Comment by cloomis [ 28/Jan/21 ] |
|
From a 2020-01-27 ICS phone con, we propose that the dcbActor itself generate two keywords, one describing the per-collimator masks and one describing the fiber bundles. And we agree that we should plan for a maximum of 12 (11?) collimators. e.g.: dcbMasks=changeMJD,mask1Name,mask2Name..mask12Name dcbBundles=changeMJD,bundle1Name,bundle2Name..bundle12Name |
| Comment by arnaud.lefur [ 28/Jan/21 ] |
|
I would prefer to split the date in another keyword if that's okay, say: dcbConfigDate=changeMJD |
| Comment by cloomis [ 28/Jan/21 ] |
|
Sure. Makes sense. If you settle on something and make the actorkeys change first I can go ahead with the ccdActor changes. Not obvious to me whether we dump the mask and bundle keys directly to FITS and always include them. I think yes. Umm, W_DMSKnn and W_DBNDnn? |