[INSTRM-1160] Move existing cron-called scripts to pfs_obs_scripts/bin Created: 15/Jan/21  Updated: 15/Jan/22  Resolved: 02/Feb/21

Status: Done
Project: Instrument control development
Component/s: ics_iicActor
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: cloomis Assignee: cloomis
Resolution: Done Votes: 0
Labels: SPS
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The stabilityTests.sh, etc. scripts are currently in ics_iicActor, and need to be moved to a more dynamic repository, the new pfs_obs_scripts.

I will check that out into /software/devel/pfs/pfs_obs_scripts and populate it there.

Will also point the crontab to call the relocated scripts, maybe with some /software/ics_launch/run_obs_script bouncer.



 Comments   
Comment by cloomis [ 16/Jan/21 ]

One top-level script: callOpsScript.sh scriptName [args], which simply calls scriptName args with output redirected to /data/logs/scripts/$scriptName/YYYY-MM-DD.log.

Moved stabilityTest.sh over from ics_iicActor; added possible masterDarks.sh. Both untested because of whatever acquisition is happening now.

Checked out to /software/devel/pfs/pfs_ops_scripts/ and eups declare --current there. I made tags for code changes, but none really needed for script additions and changes: each call is prepended by a git describe to the log.

crontab lines are a bit clumsy due to the length of the path; we might want to add some sugar, or bounce through a /software/ics_launch/bin script to do the setup and call:

#1 2-23 * * * /software/devel/pfs/pfs_ops_scripts/bin/callOpsScript.sh stabilityTest.sh
#1 0 * * * /software/devel/pfs/pfs_ops_scripts/bin/callOpsScript.sh masterDarks.sh

Oh, the package is pfs_ops_scripts, not pfs_obs_scripts.

Comment by cloomis [ 02/Feb/21 ]

This was a new repo for this, so I thoughtlessly put the work on master.

The ops scripts themselves are in the scripts/ directory, and should be called via the bin/callOpsScript.sh wrapper. See the last comment, or the pfs crontab.

Generated at Sat Feb 10 16:32:30 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.