[INSTRM-1155] Merge FPS-over-MCS and cobraCharmer camera logic Created: 09/Jan/21 Updated: 14/Aug/21 Resolved: 14/Aug/21 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_cobraCharmer, ics_fpsActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | cloomis |
| Resolution: | Done | Votes: | 0 |
| Labels: | PFI | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 2 |
| Description |
|
The fpsActor commands the mcsActor to acquire images and generate spot lists. The cobraCharmer library has a tree of classes which allow commanding one of several local camera to generate spot lists. The two interfaces are similar but not identical, and the cobraCharmer library also handles some desirable per-run (convergence test, motor map generation, etc) book-keeping. Merge the two. I'll add an mcsActor "camera" subclass to the cobraCharmer/cobraCoach library and have the fpsActor call that. It would have been cleaner to have put all the local cameras into mcsActor at the start, but that was always going to make other development clumsier. Correctly factoring out spot assignment functionality so that can easily be split between fps and mcs is not part of this, but that will be kept in mind. |
| Comments |
| Comment by chyan [ 12/Apr/21 ] |
|
I have establish a ticket branch tickets/ |
| Comment by hassan [ 13/Aug/21 ] |
|
PR has been merged. Can we close this ticket? |
| Comment by cloomis [ 14/Aug/21 ] |
|
The work as described in the ticket was mostly done in the ics_cobraCharmer work for the closed |